Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Following a link to a thread takes the user to the timeline #5567

Closed
frakic opened this issue Mar 17, 2022 · 2 comments · Fixed by #5594
Closed

Following a link to a thread takes the user to the timeline #5567

frakic opened this issue Mar 17, 2022 · 2 comments · Fixed by #5594
Assignees
@ariskotsomitopoulos
Labels
A-Threads An issue for the Threads project O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally

Comments

@frakic
Copy link
Contributor

frakic commented Mar 17, 2022

Steps to reproduce

  1. Where are you starting? What can you see?
    -I'm in an existing thread
  2. What do you click?
    -I tap on "Copy link to thread" in options
  3. More steps…
    -I follow the link

Outcome

What did you expect?

I expected to be taken to that thread

What happened instead?

I landed on the timeline instead

Your phone model

Samsung Galaxy A40

Operating system version

Android 11

Application version and app store

1.4.6-dev [40104060] (G-b6874) feature/aris/thread_live_thread_list

Homeserver

matrix.org

Will you send logs?

No
@frakic frakic added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Mar 17, 2022
@frakic frakic added A-Threads An issue for the Threads project Z-ThreadsInternalTesting Issue found while testing Threads internally labels Mar 17, 2022
@ariskotsomitopoulos
Copy link
Contributor

ariskotsomitopoulos commented Mar 17, 2022 •
edited
Loading

That is the behaviour we discussed to implement. User will be navigated to the root message in the main timeline, and can enter the thread if he wants. If there is a permalink in a thread message, it will automatically redirect user inside the thread

@novocaine novocaine added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Mar 17, 2022
@novocaine
Copy link

@janogarcia indicated we should fix this as it will be consistent with iOS

@ariskotsomitopoulos ariskotsomitopoulos mentioned this issue Mar 21, 2022
Merged
@mnaturel mnaturel mentioned this issue Mar 31, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ariskotsomitopoulos ariskotsomitopoulos

Labels
A-Threads An issue for the Threads project O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Labs Z-ThreadsInternalTesting Issue found while testing Threads internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve permalink on thread root message element-hq/element-android
3 participants
@novocaine @frakic @ariskotsomitopoulos