Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a plurals for message_reaction_show_more #5227

Closed
bmarty opened this issue Feb 14, 2022 · 2 comments · Fixed by #5304
Closed

Use a plurals for message_reaction_show_more #5227

bmarty opened this issue Feb 14, 2022 · 2 comments · Fixed by #5304
Assignees
@ganfra
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Milestone
WTF ready list

Comments

@bmarty
Copy link
Member

bmarty commented Feb 14, 2022

You should have used a plurals :/

Originally posted by @bmarty in #5204 (comment)
@bmarty bmarty changed the title Used a plurals for message_reaction_show_more Use a plurals for message_reaction_show_more Feb 14, 2022
@ouchadam ouchadam added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Feb 15, 2022
@bmarty
Copy link
Member Author

bmarty commented Feb 17, 2022

check with a few languages with Google translate (Russian, Hungarian, etc.), I think it's safer to use a plurals, at worse it will be useless.

@bmarty bmarty added this to the WTF ready list milestone Feb 17, 2022
@ahmed-radhouane ahmed-radhouane self-assigned this Feb 22, 2022
@bmarty
Copy link
Member Author

bmarty commented Feb 22, 2022

Also reported by lint as a potential plural:

image

bmarty added a commit that referenced this issue Feb 22, 2022
@bmarty
Use plurals for message_reaction_show_more. Fixes #5227
1ce65d7
@bmarty bmarty mentioned this issue Feb 22, 2022
Merged
@ahmed-radhouane ahmed-radhouane removed their assignment Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ganfra ganfra

Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
WTF ready list
Development

Successfully merging a pull request may close this issue.

Weblate 1 4 2 element-hq/element-android
4 participants
@ouchadam @bmarty @ganfra @ahmed-radhouane