Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus search bar when opening Reactions view #3869

Closed
kittykat opened this issue Aug 19, 2021 · 4 comments · Fixed by #4155
Closed

Focus search bar when opening Reactions view #3869

kittykat opened this issue Aug 19, 2021 · 4 comments · Fixed by #4155
Assignees
@bmarty
Labels
A-Reactions T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Milestone
Sprint - Element ...

Comments

@kittykat
Copy link
Contributor

To Reproduce

Steps to reproduce the behavior:

  1. Press and hold on a message to pop up menu
  2. Click on 'Add Reaction' (why is "Add Reaction" capitalised like that, while "Report content" is the other way?)

Expected behaviour

Search is focused (like on other apps)

Actual behaviour

Search is not focused and clicking in the "top bar" area doesn't bring it up, only the search icon does

Smartphone (please complete the following information):

  • Device: Pixel 2
  • OS: Android 11

Additional context

  • App store, version 1.1.15 [40101152] (G-b2969)
  • Homeserver: matrix.org
@kittykat kittykat added enhancement A-Reactions T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements and removed enhancement labels Aug 19, 2021
@ryg-git
Copy link
Contributor

ryg-git commented Sep 25, 2021

If it is okay I would like to work on this issue.

@bmarty
Copy link
Member

bmarty commented Sep 25, 2021

@ryg-git sure, thanks for letting us know!

@bmarty bmarty mentioned this issue Sep 28, 2021
Merged
6 tasks
@bmarty
Copy link
Member

bmarty commented Sep 28, 2021 •
edited
Loading

why is "Add Reaction" capitalised like that, while "Report content" is the other way?

@kittykat I would be happy to harmonize the capitalization. This is what we have now:

image

So maybe change "Add Reaction" to "Add reaction" and "View Source" to "View source" (only visible in developer mode) would be OK. Do you confirm?

[Edit] EleWeb use "React" and "Report" FWIW

@bmarty bmarty added this to the Sprint - Element 1.3.1 milestone Sep 28, 2021
@bmarty bmarty self-assigned this Oct 4, 2021
bmarty added a commit that referenced this issue Oct 4, 2021
@bmarty
Update wording in message bottom sheet (#3869)
6669587
@bmarty bmarty mentioned this issue Oct 4, 2021
Merged
onurays pushed a commit that referenced this issue Oct 5, 2021
Merge branch 'develop' into feature/ons/fallback_keys
c7bb75b 
* develop: (350 commits)
  Remove redundancy in heading in bug report issue form
  Fix typo: your->you're
  Minimize the use of exported="true" in android Manifest  - Add comments on Add exported="true" attributes  - Disable manifest exporting for:       - (service) VectorConnectionService       - (receiver) MediaButtonReceiver
  Add a log to get info when an error occurred when recording / playing voice message Will help debugging issues like #3904
  Fix test compilation
  changelog
  Create extension `String.isMxcUrl()`
  Improve code
  Load existing DM instead of creating a new one
  Remove unused SendRelationWorker and related API call (3588)
  Fix compilation issue
  changelog
  Message bottom sheet: move "View Reactions" action just below "Add Reaction"
  Update wording in message bottom sheet (#3869)
  Troubleshoot notification: Fix button not clickable
  Improve reusability of code
  Update changelog
  Add missing proper configuration for manual publishing of alias
  limit alias length in candidateAliasFromRoomName()
  Create MatrixConstants to handle max alias length limitation
  ...
@bmarty
Copy link
Member

bmarty commented Oct 8, 2021

in EA 1.3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Reactions T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
Sprint - Element 1.3.2
Development

Successfully merging a pull request may close this issue.

Wording update element-hq/element-android
3 participants
@kittykat @bmarty @ryg-git