Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code is not using jetpack or Android Architecture Components #2

Closed
sandys opened this issue Nov 11, 2018 · 2 comments
Closed

code is not using jetpack or Android Architecture Components #2

sandys opened this issue Nov 11, 2018 · 2 comments

Comments

@sandys
Copy link

sandys commented Nov 11, 2018

after the deprecation of onRetainCustomNonConfigurationInstance last week, there is really no way to save data on configuration change (rotation, etc) without using ViewModels and Architecture Components.

You guys need to use AAC, Jetpack and Viewmodels asap. you can do some of this easily (https://developer.android.com/jetpack/androidx/migrate).

But you need to write the ViewModels by hand.
@ganfra
Copy link
Member

ganfra commented Nov 12, 2018

You are maybe talking about the current Riot application (https://github.com/vector-im/riot-android).
This repo is a prototype for the new SDK and new design of Riot, and it does use AAC.

@ganfra ganfra closed this as completed Nov 12, 2018
ganfra added a commit that referenced this issue Nov 14, 2018
@ganfra
Introduce state index trying to replicate RoomState logic. WIP #2
18af7c8
@bmarty bmarty mentioned this issue Jan 8, 2019
Open
@bmarty
Copy link
Member

bmarty commented Jan 8, 2019

@sandys I've created element-hq/riot-android#2839.

ganfra added a commit that referenced this issue Jan 10, 2019
@ganfra
Add to backstack when navigating from permalink in room details #2
b5e99d0
ganfra added a commit that referenced this issue Jan 14, 2019
@ganfra
Add to backstack when navigating from permalink in room details #2
281c25e
bmarty added a commit that referenced this issue Sep 18, 2019
@bmarty
test env on Buildkite
c292f7e 
test env on Buildkite #2
bmarty added a commit that referenced this issue Oct 11, 2019
@bmarty
Try to fix the bottom sheet showing expanded by default #2
684ff73 
Seems ok now
bmarty added a commit that referenced this issue Oct 21, 2019
@bmarty
Try to fix the bottom sheet showing expanded by default #2
0bcc84c 
Seems ok now
ganfra added a commit that referenced this issue Jan 15, 2020
@ganfra
Clean code after Benoit's review #2
b44ddcf
bmarty added a commit that referenced this issue Mar 5, 2020
@bmarty
Create asValidObject method - make it compiles #2
e326631
bmarty added a commit that referenced this issue Mar 6, 2020
@bmarty
Rename to respect naming convention #2
5d0e917
squarepupil added a commit to squarepupil/riotX-android that referenced this issue Jul 26, 2020
@squarepupil
Test change element-hq#2
3324793
bmarty added a commit that referenced this issue Jan 22, 2021
@bmarty
Improve code #2
887da0a
ouchadam pushed a commit that referenced this issue Feb 7, 2022
@daniellekirkwood
Merge pull request #2 from daniellekirkwood/daniellekirkwood-patch-1
1d2da0c
ganfra pushed a commit that referenced this issue Aug 24, 2022
Try mvrx mock/launcher on RoomProfileFragment #2
ace0187
leeashlee pushed a commit to leeashlee/animent-android that referenced this issue Aug 29, 2023
@tulir
Add navbar and switch to sass. Fixes element-hq#2
9a06d63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sandys @bmarty @ganfra