Code review fixes.

element-hq · Mar 17, 2022 · a13ba13 · a13ba13
1 parent 33e5a20
commit a13ba13
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/vector/src/main/java/im/vector/app/core/utils/PermissionsTools.kt b/vector/src/main/java/im/vector/app/core/utils/PermissionsTools.kt
@@ -128,6 +128,7 @@ fun checkPermissions(permissionsToBeGranted: List<String>,
                     .setPositiveButton(R.string.ok) { _, _ ->
                         activityResultLauncher.launch(missingPermissions.toTypedArray())
                     }
+                    .setNegativeButton(R.string.action_not_now, null)
                     .show()
         } else {
             // some permissions are not granted, ask permissions

diff --git a/...efaultLocationSharingSettingsNavigator.kt → ...cation/DefaultLocationSharingNavigator.kt b/...efaultLocationSharingSettingsNavigator.kt → ...cation/DefaultLocationSharingNavigator.kt
@@ -19,7 +19,7 @@ package im.vector.app.features.location
 import android.app.Activity
 import im.vector.app.core.utils.openAppSettingsPage
 
-class DefaultLocationSharingSettingsNavigator constructor(val activity: Activity?) : LocationSharingSettingsNavigator {
+class DefaultLocationSharingNavigator constructor(val activity: Activity?) : LocationSharingNavigator {
 
     override var goingToAppSettings: Boolean = false
 

diff --git a/vector/src/main/java/im/vector/app/features/location/LocationSharingFragment.kt b/vector/src/main/java/im/vector/app/features/location/LocationSharingFragment.kt
@@ -54,7 +54,7 @@ class LocationSharingFragment @Inject constructor(
 
     private val viewModel: LocationSharingViewModel by fragmentViewModel()
 
-    private val locationSharingNavigator: LocationSharingSettingsNavigator by lazy { DefaultLocationSharingSettingsNavigator(activity) }
+    private val locationSharingNavigator: LocationSharingNavigator by lazy { DefaultLocationSharingNavigator(activity) }
 
     // Keep a ref to handle properly the onDestroy callback
     private var mapView: WeakReference<MapView>? = null

diff --git a/...ation/LocationSharingSettingsNavigator.kt → ...ures/location/LocationSharingNavigator.kt b/...ation/LocationSharingSettingsNavigator.kt → ...ures/location/LocationSharingNavigator.kt
@@ -16,7 +16,7 @@
 
 package im.vector.app.features.location
 
-interface LocationSharingSettingsNavigator {
+interface LocationSharingNavigator {
     var goingToAppSettings: Boolean
     fun quit()
     fun goToAppSettings()