Insert room shortcuts in order

This prevents shortcuts from momentarily being shown out of order while the shortcut list is in the process of being updated.
element-hq · Aug 25, 2021 · 2004d35 · 2004d35
1 parent 842ccb1
commit 2004d35
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/vector/src/main/java/im/vector/app/features/home/ShortcutCreator.kt b/vector/src/main/java/im/vector/app/features/home/ShortcutCreator.kt
@@ -58,7 +58,7 @@ class ShortcutCreator @Inject constructor(
     }
 
     @WorkerThread
-    fun create(roomSummary: RoomSummary): ShortcutInfoCompat {
+    fun create(roomSummary: RoomSummary, rank: Int = 1): ShortcutInfoCompat {
         val intent = RoomDetailActivity.shortcutIntent(context, roomSummary.roomId)
         val bitmap = try {
             avatarRenderer.shortcutDrawable(GlideApp.with(context), roomSummary.toMatrixItem(), iconSize)
@@ -70,6 +70,7 @@ class ShortcutCreator @Inject constructor(
                 .setIcon(bitmap?.toProfileImageIcon())
                 .setIntent(intent)
                 .setLongLived(true)
+                .setRank(rank)
 
                 // Make it show up in the direct share menu
                 .setCategories(setOf(

diff --git a/vector/src/main/java/im/vector/app/features/home/ShortcutsHandler.kt b/vector/src/main/java/im/vector/app/features/home/ShortcutsHandler.kt
@@ -58,9 +58,9 @@ class ShortcutsHandler @Inject constructor(
                             .filter { !roomIds.contains(it) }
                     ShortcutManagerCompat.removeLongLivedShortcuts(context, deadShortcutIds)
 
-                    val shortcuts = rooms
-                            .asReversed()
-                            .map { shortcutCreator.create(it) }
+                    val shortcuts = rooms.mapIndexed { index, room ->
+                        shortcutCreator.create(room, index)
+                    }
 
                     shortcuts.forEach { shortcut ->
                         ShortcutManagerCompat.pushDynamicShortcut(context, shortcut)