Rename method and class for more clarity

element-hq · Nov 27, 2020 · 0ac04eb · 0ac04eb
1 parent c96aee8
commit 0ac04eb
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/vector/src/main/java/im/vector/app/features/roomprofile/RoomProfileActivity.kt b/vector/src/main/java/im/vector/app/features/roomprofile/RoomProfileActivity.kt
@@ -99,11 +99,11 @@ class RoomProfileActivity :
                 .observe()
                 .subscribe { sharedAction ->
                     when (sharedAction) {
-                        is RoomProfileSharedAction.OpenRoomMembers       -> openRoomMembers()
-                        is RoomProfileSharedAction.OpenRoomSettings      -> openRoomSettings()
-                        is RoomProfileSharedAction.OpenRoomAlias         -> openRoomAlias()
-                        is RoomProfileSharedAction.OpenRoomUploads       -> openRoomUploads()
-                        is RoomProfileSharedAction.OpenBannedRoomMembers -> openBannedRoomMembers()
+                        is RoomProfileSharedAction.OpenRoomMembers         -> openRoomMembers()
+                        is RoomProfileSharedAction.OpenRoomSettings        -> openRoomSettings()
+                        is RoomProfileSharedAction.OpenRoomAliasesSettings -> openRoomAlias()
+                        is RoomProfileSharedAction.OpenRoomUploads         -> openRoomUploads()
+                        is RoomProfileSharedAction.OpenBannedRoomMembers   -> openBannedRoomMembers()
                     }
                 }
                 .disposeOnDestroy()

diff --git a/vector/src/main/java/im/vector/app/features/roomprofile/RoomProfileSharedAction.kt b/vector/src/main/java/im/vector/app/features/roomprofile/RoomProfileSharedAction.kt
@@ -23,7 +23,7 @@ import im.vector.app.core.platform.VectorSharedAction
  */
 sealed class RoomProfileSharedAction : VectorSharedAction {
     object OpenRoomSettings : RoomProfileSharedAction()
-    object OpenRoomAlias : RoomProfileSharedAction()
+    object OpenRoomAliasesSettings : RoomProfileSharedAction()
     object OpenRoomUploads : RoomProfileSharedAction()
     object OpenRoomMembers : RoomProfileSharedAction()
     object OpenBannedRoomMembers : RoomProfileSharedAction()

diff --git a/vector/src/main/java/im/vector/app/features/roomprofile/settings/RoomSettingsController.kt b/vector/src/main/java/im/vector/app/features/roomprofile/settings/RoomSettingsController.kt
@@ -46,7 +46,7 @@ class RoomSettingsController @Inject constructor(
         fun onNameChanged(name: String)
         fun onTopicChanged(topic: String)
         fun onHistoryVisibilityClicked()
-        fun onOpenAlias()
+        fun onRoomAliasesClicked()
     }
 
     private val dividerColor = colorProvider.getColorFromAttribute(R.attr.vctr_list_divider_color)
@@ -115,7 +115,7 @@ class RoomSettingsController @Inject constructor(
                 dividerColor = dividerColor,
                 divider = true,
                 editable = true,
-                action = { callback?.onOpenAlias() }
+                action = { callback?.onRoomAliasesClicked() }
         )
 
         buildProfileAction(

diff --git a/vector/src/main/java/im/vector/app/features/roomprofile/settings/RoomSettingsFragment.kt b/vector/src/main/java/im/vector/app/features/roomprofile/settings/RoomSettingsFragment.kt
@@ -168,8 +168,8 @@ class RoomSettingsFragment @Inject constructor(
         return@withState
     }
 
-    override fun onOpenAlias() {
-        roomProfileSharedActionViewModel.post(RoomProfileSharedAction.OpenRoomAlias)
+    override fun onRoomAliasesClicked() {
+        roomProfileSharedActionViewModel.post(RoomProfileSharedAction.OpenRoomAliasesSettings)
     }
 
     override fun onImageReady(uri: Uri?) {