Update Avatar to new design spec #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 9, 2023 06:59
SimonBrandner
approved these changes
Aug 9, 2023
|
Can we make the text weight bold to align it with the designs? The letter also looks large compared to the designs - will add an example below: 
|
|
@callumu thank you for the review! I have update the font weight, and also the font size. From all the examples i could see, the font size is equal to 56.25% of the avatar size. And i've capped the font size to a max of 60px. |
Deploying with
|
| Latest commit: |
4948c8b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0636d8b5.compound-web.pages.dev |
| Branch Preview URL: | https://germain-gg-avatar-updates.compound-web.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For element-hq/compound#137
Figma link: https://www.figma.com/file/rTaQE2nIUSLav4Tg3nozq7/Compound-Web-Components?type=design&node-id=522-742&mode=design&t=jsFgnt5eA33BaiFu-11
FAO @callumu
🤮 Before
💅 After
It also makes proper use of
forwardRefas it is needed in certain implementation, and can now receive all HTML Span attributes as props to give more flexibility, particularly on the accessibility side of things