Add help label to edit in place #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying compound-web with
|
| Latest commit: |
9a828f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://80a0ec76.compound-web.pages.dev |
| Branch Preview URL: | https://florianduros-edit-in-place.compound-web.pages.dev |
florianduros
force-pushed
the
florianduros/edit-in-place
branch
from
d8902f6 to
69b9981
Compare
florianduros
requested review from
dbkr and
t3chguy
and removed request for
a team
# Conflicts: # src/components/Form/Controls/EditInPlace/EditInPlace.test.tsx # src/components/Form/Controls/EditInPlace/EditInPlace.tsx
robintown
reviewed
Jun 18, 2024
florianduros
force-pushed
the
florianduros/edit-in-place
branch
from
f4b0a28 to
accaa1a
Compare
robintown
reviewed
Jun 18, 2024
florianduros
force-pushed
the
florianduros/edit-in-place
branch
from
accaa1a to
37666a6
Compare
robintown
approved these changes
Jun 18, 2024
| const labels: JSX.Element[] = []; | ||
| if (error) { | ||
| labels.push( | ||
| <div className={styles["caption-line"]} key={error}> |
There was a problem hiding this comment.
This is probably okay, but I would go for static keys like key="error" because technically nothing is stopping two labels from having the same text. It also allows React to produce a more fine-grained diff when the text of a label changes.
florianduros
force-pushed
the
florianduros/edit-in-place
branch
from
37666a6 to
9a828f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a help message according to the figma design https://www.figma.com/design/rTaQE2nIUSLav4Tg3nozq7/Compound-Web-Components?node-id=4335-2016&t=m2StPHnu3yvpsXaj-4