Make title optional on Menu #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying compound-web with
|
| Latest commit: |
937c67b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://936ebbbf.compound-web.pages.dev |
| Branch Preview URL: | https://dbkr-menu-optional-title.compound-web.pages.dev |
and fix it so the title wasn't ignored
t3chguy
reviewed
May 28, 2024
|
Not sure what you mean... there is no prop for label, or were you suggesting adding one? |
|
Yes, given right now label=title via labelled-by, this change makes the menu able to be label-less which is poor a11y |
So we always have a label of some kind for a11y
t3chguy
requested changes
May 29, 2024
Co-authored-by: Michael Telatynski <[email protected]>
t3chguy
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.