Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major dependency updates #172

Merged
merged 7 commits into from
May 16, 2024
Merged

Major dependency updates #172

merged 7 commits into from
May 16, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented May 15, 2024

  • Storybook 8
  • Vite 5
  • Vitest 1

There are a lot of changes from Storybook 7 to 8. I believe this should work. The migration tool helped (sorta) but if you spot anything broken, it could be this.

Removes storybook-addon-jsx because it doesn't appear tgo be compatible with storybook 8 (uses @storybook/addons) and hasn't been updated since 2021.

 * Storybook 8
 * Vite 5
 * Vitest 1

Removes storybook-addon-jsx because it doesn't appear tgo be compatible
with storybook 8 (uses @storybook/addons) and hasn't been updated since 2021.

Tests not passing yet
@dbkr dbkr added the task label May 15, 2024
Copy link

cloudflare-workers-and-pages bot commented May 15, 2024

Deploying compound-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: a9741f9
Status: ✅  Deploy successful!
Preview URL: https://22cc77c1.compound-web.pages.dev
Branch Preview URL: https://dbkr-upgrade-all-the-things.compound-web.pages.dev

View logs

@@ -0,0 +1 @@
20.13.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bumps the node version that cloudflare pages uses. It's a shame we can't comment this file. :/

@dbkr dbkr marked this pull request as ready for review May 15, 2024 16:19
@dbkr dbkr requested a review from a team as a code owner May 15, 2024 16:19
@dbkr dbkr requested review from robintown and removed request for a team May 15, 2024 16:19
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch for doing this!

@dbkr dbkr merged commit 0467d51 into main May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants