Memoize cloned element in tooltip #167
Conversation
Deploying compound-web with
|
| Latest commit: |
05e7e3d
|
| Status: | ⚡️ Build in progress... |
florianduros
requested review from
dbkr and
robintown
and removed request for
a team
src/components/Tooltip/Tooltip.tsx
Outdated
| ...children.props, | ||
| }); | ||
| return cloneElement(children, props); | ||
| }, [ref, children, isValidElement(children) && children.props]); |
There was a problem hiding this comment.
&& here is unexpected, it implies breaking rules-of-hooks, can it get a comment to explain it?
There was a problem hiding this comment.
Why is it breaking the rules of hooks? I can declare it before but it doesn't change anything to me
There was a problem hiding this comment.
Looks like this project doesn't use https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks which has rules-of-hooks. https://www.reddit.com/r/reactjs/comments/13oy1r5/is_eslint_exhaustive_deps_a_bad_rule_sometimes/
There was a problem hiding this comment.
Oh I see. I added a comment. It's needed to be able to infer the type of children to have access to the props field.
There was a problem hiding this comment.
I was more questioning why && instead of , - a comment or maybe breaking it out into a sanely named variable could go a long way to clarifying it
No description provided.