Edit In Place component #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying compound-web with
|
| Latest commit: |
897cabb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7c880485.compound-web.pages.dev |
| Branch Preview URL: | https://dbkr-editinplace.compound-web.pages.dev |
robintown
reviewed
May 14, 2024
There was a problem hiding this comment.
Honestly, I don't see anything wrong with keeping showSaved internal to the component. Controlled components are preferable to uncontrolled components when the parent might reasonably want to have access the child's state, but I don't think that applies to the "saved" text here - it just isn't useful to know about.
Comment on lines
123
to
125
| setTimeout(() => { | ||
| setShowSaved(false); | ||
| }, 2000); |
There was a problem hiding this comment.
I believe this will log a warning if the component is unmounted while the timer is still running
and move the url to the right place
Because the error might be a failure to commit the change rather than the input being invalid.
4 tasks
So we can have a screenshot of it in its focussed state
|
Done, added as its own playwright test as it relies on the component having focus. I'm surprised we've got this far without having real playwright test tbh. |
florianduros
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A component that allows a user to edit text in place with buttons that reveal while editing.