Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: Remove useless data-state #164

Merged
merged 2 commits into from
May 2, 2024

Conversation

florianduros
Copy link
Member

This data attribute was in the floating ui example to show we can have access to some data in the internal state of the component. In our case, we don't need, it's polluting the dom.

Copy link

cloudflare-workers-and-pages bot commented May 2, 2024

Deploying compound-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: fa10434
Status: ✅  Deploy successful!
Preview URL: https://7d585b85.compound-web.pages.dev
Branch Preview URL: https://florianduros-tooltip-data-at.compound-web.pages.dev

View logs

@florianduros florianduros changed the title Remove useless data-state on tooltip Tooltip: Remove useless data-state May 2, 2024
@florianduros florianduros marked this pull request as ready for review May 2, 2024 10:18
@florianduros florianduros requested a review from a team as a code owner May 2, 2024 10:18
@florianduros florianduros requested review from dbkr and robintown and removed request for a team May 2, 2024 10:18
@florianduros florianduros merged commit b033115 into main May 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants