Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the action input overflowing of small containers #152

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

sandhose
Copy link
Member

@sandhose sandhose commented Feb 26, 2024

This is one of the weirdness of flexbox. See https://dfmcphee.com/flex-items-and-min-width-0/

Before: (Storybook)
image

After: (Storybook)
image

@sandhose sandhose requested a review from a team as a code owner February 26, 2024 16:22
Copy link

cloudflare-workers-and-pages bot commented Feb 26, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 70a6b6a
Status: ✅  Deploy successful!
Preview URL: https://bc4b115c.compound-web.pages.dev
Branch Preview URL: https://quenting-action-input-min-wi.compound-web.pages.dev

View logs

@sandhose sandhose requested review from t3chguy and robintown and removed request for a team February 26, 2024 16:22
@sandhose sandhose force-pushed the quenting/action-input-min-width branch from e367922 to 70a6b6a Compare February 26, 2024 16:24
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never seen min-inline-size - EW normally uses min-width for the same trick but its probs fine

@sandhose sandhose merged commit db837bd into main Feb 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants