Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip: rename shortcut to caption and styling fixes #103

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Oct 12, 2023

Fixes element-hq/compound#246
Following the discussion on #102

@germain-gg germain-gg requested a review from a team as a code owner October 12, 2023 07:52
@germain-gg germain-gg requested review from dbkr and removed request for a team October 12, 2023 07:52
@germain-gg germain-gg changed the title Rename shortcut to sublabel Tooltip: rename shortcut to sublabel Oct 12, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 12, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2f33064
Status: ✅  Deploy successful!
Preview URL: https://fb3efcf7.compound-web.pages.dev
Branch Preview URL: https://germain-gg-tooltip-naming.compound-web.pages.dev

View logs

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

element-hq/compound#246 says to use caption with sensible reasoning over other options

@germain-gg germain-gg changed the title Tooltip: rename shortcut to sublabel Tooltip: rename shortcut to caption Oct 12, 2023
@germain-gg germain-gg requested a review from t3chguy October 12, 2023 07:58
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the PR title to include the change from small->span also? Thanks for the compat

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button

@germain-gg germain-gg changed the title Tooltip: rename shortcut to caption Tooltip: rename shortcut to caption and styling fixes Oct 12, 2023
@germain-gg germain-gg merged commit 2f7f7c4 into main Oct 12, 2023
7 checks passed
@germain-gg germain-gg deleted the germain-gg/tooltip-naming branch October 12, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvement to shortcut property in Web Tooltip component
2 participants