Quick nudge for onset/offset in sampleseq

elemaudio · Jan 11, 2024 · acf1757 · acf1757
1 parent b4a8ed6
commit acf1757
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/js/packages/offline-renderer/elementary-wasm.js b/js/packages/offline-renderer/elementary-wasm.js
diff --git a/js/packages/web-renderer/raw/elementary-wasm.js b/js/packages/web-renderer/raw/elementary-wasm.js
diff --git a/runtime/elem/builtins/SampleSeq.h b/runtime/elem/builtins/SampleSeq.h
@@ -221,7 +221,11 @@ namespace elem
                 readers[activeReader].disengage();
                 activeReader = (activeReader + 1) & (readers.size() - 1);
 
-                readers[activeReader].engage(prevEvent->first);
+                // Here a value of 1.0 is considered an onset, and anything else
+                // considered an offset.
+                if (detail::fpEqual(prevEvent->second, FloatType(1.0))) {
+                    readers[activeReader].engage(prevEvent->first);
+                }
             }
         }