Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace colors with chalk #949

Merged
merged 1 commit into from
Jan 9, 2022

Conversation

malept
Copy link
Member

@malept malept commented Jan 9, 2022

Fixes #948.

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes LGTM, looks like CI is still failing 🤔

test/fixture/native-app1/package.json Outdated Show resolved Hide resolved
yarn.lock Show resolved Hide resolved
@malept malept force-pushed the malept/fix/replace-colors-with-chalk branch from a769d72 to 75f3fc1 Compare January 9, 2022 16:29
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2022

Codecov Report

Merging #949 (75f3fc1) into master (5e48a60) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #949   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files          19       19           
  Lines         686      686           
  Branches      131      131           
=======================================
  Hits          524      524           
  Misses        118      118           
  Partials       44       44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e48a60...75f3fc1. Read the comment docs.

@malept malept merged commit daed48b into master Jan 9, 2022
@malept malept deleted the malept/fix/replace-colors-with-chalk branch January 9, 2022 16:42
@electron-bot
Copy link

🎉 This PR is included in version 3.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unreadable output while using electron-rebuild
4 participants