fix: use node-gyp as a module instead of shelling out #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: extract module rebuilding to its own class
malept
force-pushed
the
malept/refactor/node-gyp-module
branch
from
6bbc342 to
725149c
Compare
vhashimotoo
approved these changes
Sep 3, 2020
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically it's a refactor, but it's also a fix/perf improvement. Tests run significantly faster probably because it removes a layer of indirection (i.e., shelling out). I believe we may be able to do something similar with
prebuild-installand just get rid of@malept/cross-spawn-promiseas a dependency (still needs to be a devDependency).This is ported from #363
Additionally, it refactors
locateBinaryto be a little more efficient in the worst case.