Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rcedit and asar #467

Merged
merged 2 commits into from
Aug 24, 2016
Merged

Upgrade rcedit and asar #467

merged 2 commits into from
Aug 24, 2016

Conversation

kevinsawicki
Copy link
Contributor

@kevinsawicki kevinsawicki commented Aug 22, 2016

I believe #53 can now be closed after this gets merged, several errors are mentioned in that issue that have now been addressed in rcedit such as missing .ddl errors, non-ASCII path issues, and others.

Closes #53

@malept malept added this to the 8.0.0 milestone Aug 22, 2016
@malept
Copy link
Member

malept commented Aug 22, 2016

👍 assuming that tests pass.

Side note, you should use the PR template, if only to provide a good example for potential contributors 😄

@kevinsawicki
Copy link
Contributor Author

Side note, you should use the PR template, if only to provide a good example for potential contributors

Thanks for mentioning that, will do in the future 👍

@kevinsawicki kevinsawicki force-pushed the upgrade-rcedit-and-asar branch 3 times, most recently from ce66033 to 08a322d Compare August 23, 2016 23:47
@malept malept merged commit 3370060 into master Aug 24, 2016
@malept malept deleted the upgrade-rcedit-and-asar branch August 24, 2016 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rcedit.exe is not working on Windows
2 participants