Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't publish test files #213

Merged
merged 1 commit into from
Nov 6, 2019
Merged

fix: Don't publish test files #213

merged 1 commit into from
Nov 6, 2019

Conversation

ffflorian
Copy link
Contributor

This PR will prevent npm from publishing the test files, the yarn lock file and the CircleCI config file.

@ffflorian
Copy link
Contributor Author

@MarshallOfSound @sethlu any update on this?

@sethlu
Copy link
Contributor

sethlu commented Nov 6, 2019

Sorry for the delay! I've been a little busy lately...

Looks good to me! Thanks for working on this 😸

@sethlu sethlu merged commit 5e62e06 into electron:master Nov 6, 2019
@ffflorian ffflorian deleted the fix/npmignore branch November 6, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants