feat: skipIdentityValidation #126
Conversation
Not documented because intended to be internal option for programmatic usage
| platform?: string; | ||
| keychain?: string; | ||
| } | ||
| declare module "electron-osx-sign" { |
There was a problem hiding this comment.
Otherwise typing is not used if module: es2015 Why es2015 module is used for node projects? Because it is transpiled by babel in the end :)
index.d.ts
Outdated
| 'requirements'?: string; | ||
| 'type'?: string; | ||
| version?: string; | ||
| skipIdentityValidation?: boolean; |
There was a problem hiding this comment.
@develar I am not sure if to order the options alphabetically or just by priority/usage frequency with skipIdentityValidation.
There was a problem hiding this comment.
I add properties by date — newest in the end. Or by group. You can reorder as you want :)
sign.js
Outdated
| @@ -219,6 +219,9 @@ var signAsync = module.exports.signAsync = function (opts) { | |||
| var promise | |||
| if (opts.identity) { | |||
| debuglog('`identity` passed in arguments.') | |||
| if (opts.skipIdentityValidation) { | |||
There was a problem hiding this comment.
I am wondering if it would be better to have this option skipIdentityValidation as identity-validation (as in the way we treat gatekeeper-assess) so the parameters are more consistent across electron-osx-sign?
There was a problem hiding this comment.
I prefer camel-case, but you are right — I will rename to identity-validation for consistency.
There was a problem hiding this comment.
@develar yea camel-case should work better with the programmable interface.
As a side question before publishing the module, would you prefer identity-validation or validate-identity as the option name?
I am thinking for future support, validate-identity may be more sustainable as the prefix validate- is generally reusable?
Ref: https://www.gnu.org/prep/standards/html_node/Option-Table.html#Option-Table
There was a problem hiding this comment.
Control question is: whether to option-name? Whether to validate identity? It is why originally name skipIdentityValidation was suggested. If we inverse and simplify — whether to validate identity.
Electron-builder has option npmRebuild, but npm here is a prefix. forceCodeSigning another example.
|
Merged; thanks @develar! I will release a latest version later today. |
|
@develar |
Not documented because intended to be internal option for programmatic usage