Do not insert com.apple.developer.team-identifier

[sethlu]

Addresses issues below:

• publishing to mac app store electron-react-boilerplate/electron-react-boilerplate#537 (comment)
• mas app crashing after signing electron-userland/electron-builder#897

[develar]

After this patch, I got error

error 20:22:49.262802 +0100 sandboxd SandboxViolation: Onshape(10261) deny network-bind /private/var/folders/3f/qqlb61zj491dnhr434dhwb8m0000gn/T/org.develar.onshape/S/SS
Violation: deny network-bind /private/var/folders/3f/qqlb61zj491dnhr434dhwb8m0000gn/T/org.develar.onshape/S/SS
Process: Onshape [10261]
Path: /Users/develar/Documents/onshape-desktop-shell/dist/mas/Onshape.app/Contents/MacOS/Onshape
Load Address: 0x10758b000
Identifier: org.develar.onshape
Version: 0.5.4 (0.5.4)
Code Type: x86_64 (Native)
Parent Process: launchd [1]
Responsible: /Users/develar/Documents/onshape-desktop-shell/dist/mas/Onshape.app/Contents/MacOS/Onshape [10261]
User ID: 501

Date/Time: 2016-11-13 20:22:49.162 GMT+1
OS Version: Mac OS X 10.12.1 (16B2555)
Report Version: 8

Thread 0 (id: 859709):
0 libsystem_kernel.dylib 0x00007fffeaf2c1ba __bind + 10
1 Electron Framework 0x0000000107c0159a ProcessSingleton::NotifyOtherProcessWithTimeoutOrCreate(base::CommandLine const&, int, base::TimeDelta const&) + 42
2 Electron Framework 0x0000000107c0155d ProcessSingleton::NotifyOtherProcessOrCreate() + 45
3 Electron Framework 0x0000000107ac884e atom::api::App::MakeSingleInstance(base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&) + 158
4 Electron Framework 0x0000000107ad7383 bool base::internal::RunnableAdapter<bool (atom::api::App::)(base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&)>::Run<atom::api::App, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::_1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&>(atom::api::App&&, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&&&) const + 35
5 Electron Framework 0x0000000107ad7359 bool base::internal::InvokeHelper<false, bool>::MakeItSo<base::internal::RunnableAdapter<bool (atom::api::App::)(base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::_1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&)> const&, atom::api::App, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&>(base::internal::RunnableAdapter<bool (atom::api::App::)(base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::_1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&)> const&&&, atom::api::App&&, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&&&) + 9
6 Electron Framework 0x0000000107ad733f bool base::internal::Invoker<base::internal::BindState<base::internal::RunnableAdapter<bool (atom::api::App::)(base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::_1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&)> >, bool (atom::api::App, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&)>::RunImpl<base::internal::RunnableAdapter<bool (atom::api::App::)(base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&)> const&, std::__1::tuple<> const&>(base::internal::RunnableAdapter<bool (atom::api::App::)(base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&)> const&&&, std::_1::tuple<> const&&&, base::IndexSequence<>, atom::api::App&&, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&) + 15
7 Electron Framework 0x0000000107ad7260 base::internal::Invoker<base::internal::BindState<base::internal::RunnableAdapter<bool (atom::api::App::_)(base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::_1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&)> >, bool (atom::api::App, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&)>::Run(base::internal::BindStateBase, atom::api::App&&, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::_1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&) + 32
8 Electron Framework 0x0000000107ad71d7 base::Callback<bool (atom::api::App, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::_1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&), (base::internal::CopyMode)1>::Run(atom::api::App, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::_1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&) const + 39
9 Electron Framework 0x0000000107ad6b72 void mate::internal::Invoker<mate::internal::IndicesHolder<0ul, 1ul>, atom::api::App, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&>::DispatchToCallback(base::Callback<bool (atom::api::App, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&), (base::internal::CopyMode)1>) + 66
10 Electron Framework 0x0000000107ad69fc mate::internal::Dispatcher<bool (atom::api::App*, base::Callback<bool (std::__1::vector<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits, std::__1::allocator > > > const&, base::FilePath const&), (base::internal::CopyMode)1> const&)>::DispatchToCallback(v8::FunctionCallbackInfov8::Value const&) + 124
11 libnode.dylib 0x000000010bb8c73a v8::internal::FunctionCallbackArguments::Call(void ()(v8::FunctionCallbackInfov8::Value const&)) + 298
12 libnode.dylib 0x000000010bbc69be
13 libnode.dylib 0x000000010bbf124f
14 0x00002668f9406147
15 0x00002668f957986a
16 0x00002668f954e11c
17 0x00002668f9549e6b
18 0x00002668f9548892
19 0x00002668f95483bd
20 0x00002668f953b826
21 0x00002668f955024e
22 0x00002668f954e11c
23 0x00002668f9549e6b
24 0x00002668f9548892
25 0x00002668f95483bd
26 0x00002668f953b826
27 0x00002668f953b330
28 0x00002668f953b1d9
29 0x00002668f946ac8e
30 0x00002668f9468d98
31 0x00002668f9442263
32 0x00002668f9425d6f
33 libnode.dylib 0x000000010beacf10
34 libnode.dylib 0x000000010beacd19 v8::internal::Execution::Call(v8::internal::Isolate, v8::internal::Handlev8::internal::Object, v8::internal::Handlev8::internal::Object, int, v8::internal::Handlev8::internal::Object_) + 313
35 libnode.dylib 0x000000010bb7916d v8::Function::Call(v8::Localv8::Context, v8::Localv8::Value, int, v8::Localv8::Value_) + 541
36 libnode.dylib 0x000000010b8d0c22 node::LoadEnvironment(node::Environment_) + 386
37 Electron Framework 0x0000000107bdbaa2 atom::NodeBindings::LoadEnvironment(node::Environment_) + 18
38 Electron Framework 0x0000000107b61d97 atom::AtomBrowserMainParts::PostEarlyInitialization() + 311
39 Electron Framework 0x00000001084024a3
40 Electron Framework 0x00000001084079c8
41 Electron Framework 0x0000000108401c35
42 Electron Framework 0x000000010836d440
43 Electron Framework 0x000000010836c626
44 Electron Framework 0x0000000107ac3107 AtomMain + 71
45 Onshape 0x000000010758bf26 main + 38
46 libdyld.dylib 0x00007fffeadfe255 start + 1
47 Onshape 0x0000000000000001

Thread 1 (id: 859733):
0 libsystem_kernel.dylib 0x00007fffeaf2d4e6 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fffeb015211 start_wqthread + 13

Thread 2 (id: 859734):
0 libsystem_kernel.dylib 0x00007fffeaf2d4e6 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fffeb015211 start_wqthread + 13
2 0x6d68537365636e65

Thread 3 (id: 859735):
0 libsystem_kernel.dylib 0x00007fffeaf2d4e6 __workq_kernreturn + 10
1 libsystem_pthread.dylib 0x00007fffeb015211 start_wqthread + 13

Thread 4 (id: 859750, WorkerPool/13827):
0 libsystem_kernel.dylib 0x00007fffeaf2cc8a __psynch_cvwait + 10
1 Electron Framework 0x0000000107cf6f2b
2 Electron Framework 0x0000000107d0984d
3 Electron Framework 0x0000000107d09c73
4 Electron Framework 0x0000000107d03ff7
5 libsystem_pthread.dylib 0x00007fffeb015aab _pthread_body + 180
6 libsystem_pthread.dylib 0x00007fffeb0159f7 _pthread_body + 0
7 libsystem_pthread.dylib 0x00007fffeb015221 thread_start + 13

Thread 5 (id: 859753, WorkerPool/13587):
0 libsystem_kernel.dylib 0x00007fffeaf2cc8a __psynch_cvwait + 10
1 Electron Framework 0x0000000107cf6f2b
2 Electron Framework 0x0000000107d0984d
3 Electron Framework 0x0000000107d09c73
4 Electron Framework 0x0000000107d03ff7
5 libsystem_pthread.dylib 0x00007fffeb015aab _pthread_body + 180
6 libsystem_pthread.dylib 0x00007fffeb0159f7 _pthread_body + 0
7 libsystem_pthread.dylib 0x00007fffeb015221 thread_start + 13

Thread 6 (id: 859760, WorkerPool/15371):
0 libsystem_kernel.dylib 0x00007fffeaf2cc8a __psynch_cvwait + 10
1 Electron Framework 0x0000000107cf6f2b
2 Electron Framework 0x0000000107d0984d
3 Electron Framework 0x0000000107d09c73
4 Electron Framework 0x0000000107d03ff7
5 libsystem_pthread.dylib 0x00007fffeb015aab _pthread_body + 180
6 libsystem_pthread.dylib 0x00007fffeb0159f7 _pthread_body + 0
7 libsystem_pthread.dylib 0x00007fffeb015221 thread_start + 13

Binary Images:
0x10758b000 - 0x10758bff7 org.develar.onshape (0.5.4 - 0.5.4) <94e6e648-8c7e-30d8-a501-0bff7fd691ad> /Users/develar/Documents/onshape-desktop-shell/dist/mas/Onshape.app/Contents/MacOS/Onshape
0x107ac1000 - 0x10af43feb com.github.electron.framework /Users/develar/Documents/onshape-desktop-shell/dist/mas/Onshape.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework
0x10b7ea000 - 0x10c554ffb libnode.dylib (0) <46b87f18-0cc2-38f4-9e4e-4d4d789eaf74> /Users/develar/Documents/onshape-desktop-shell/dist/mas/Onshape.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Libraries/libnode.dylib
0x7fffeadf9000 - 0x7fffeadfeff3 libdyld.dylib (421.2) <7bfa3476-6210-3bcb-8ce8-9b952f87bd84> /usr/lib/system/libdyld.dylib
0x7fffeaf13000 - 0x7fffeaf35ff7 libsystem_kernel.dylib (3789.21.3) /usr/lib/system/libsystem_kernel.dylib
0x7fffeb012000 - 0x7fffeb01cff7 libsystem_pthread.dylib (218.20.1) <46375095-4731-3034-9d87-396de95fc697> /usr/lib/system/libsystem_pthread.dylib

[develar]

I get the same error using old version of electron-osx-sign, so, I assume it is not related to this issue.

Thank you for quick fix.

[sethlu]

@develar I haven't had time to test this patch just yet. However with the latest Electron releases...

• If the app is built (mas) with --type=development and with provisioning profile for development, no error should be raised. If no provisioning profile is provided, app will freeze at launch while emitting some errors in Console.
• If the app is built (mas) with --type=distribution (or by default distribution) app will freeze whether or not a provisioning profile is embedded because distributional app is no longer to be run locally.
• In any case, from my testing, the app launches without throwing errors except some to do with OpenGL with this patch applied.

Would you let me know which case you are dealing with right now?

[sethlu]

@develar original intent of this entitlement key:

Recently, the com.apple.developer.team-identifier entitlement was added to all new Mac provisioning profiles. This means that, going forward, distribution builds of Mac apps cannot be run directly; they are for submitting to iTunes Connect for app review only.

Instead, developers should adopt the Archive Build Workflow in QA1778: How to reproduce bugs reported against Mac App Store submissions for testing the builds that they plan to submit for the Mac App Store. On Xcode 6, select Export as a Mac Application. You won't see any chance to select your development signing identity, but Xcode will export the app from the archive as it was signed at build time. So the result will be the same.

Ref: https://developer.apple.com/library/content/qa/qa1884/_index.html

So I think it is better to keep this entitlement as it enforces the Apple documentation.