Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto entitlements broke in last update #135

Closed
feens opened this issue May 31, 2017 · 2 comments
Closed

Auto entitlements broke in last update #135

feens opened this issue May 31, 2017 · 2 comments
Labels

Comments

@feens
Copy link

feens commented May 31, 2017

I've done some digging to figure out the exact issue:

  • In the last commit, you switched to using a Hash for code sign, and thus return a hash for the identity option instead of the string (see f1b226a)
  • In the entitlements utility, if ElectronTeamID isn't in Info.plist, you use opts.identity to parse out the value from the identity option (see https://github.com/electron-userland/electron-osx-sign/blob/master/util-entitlements.js#L53)
  • Being as the identity value is now a Hash instead of the identity string, this fails and causes an incorrect value to be added to com.apple.security.application-groups array, even if the correct value already exists

One other note: when using electron-builder, the identity is actually passed as an option, so it would probably to use that rather than looking in the Info.plist

@sethlu
Copy link
Contributor

sethlu commented Jun 1, 2017

Hi @feens, thanks for reporting this issue! I will post a fix for this shortly.

sethlu added a commit to sethlu/electron-osx-sign that referenced this issue Jun 1, 2017
@sethlu
Copy link
Contributor

sethlu commented Jun 2, 2017

@feens, I've released v0.4.6 which should address this issue since v0.4.5. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants