Merge pull request #100 from salomvary/allow-skipping-gatekeeper

Allow skipping Gatekeper check

README.md

@@ -150,6 +150,12 @@ Default to system default keychain.
 Regex or function that signals ignoring a file before signing.
 Default to `undefined`.
 
+`gatekeeper-assess` - *Boolean*
+
+Flag to enable Gatekeeper assessment after signing the app. Disabling it is useful for signing with self-signed certificates.
+Gatekeeper assessment is enabled by default on `darwin` platform.
+Default to `true`.
+
 `platform` - *String*
 
 Build platform of Electron.

bin/electron-osx-sign-usage.txt

@@ -35,6 +35,10 @@ DESCRIPTION
     The keychain name.
     Default to system default keychain.
 
+  --gatekeeper-assess, --no-gatekeeper-assess
+    Flag to enable Gatekeeper assessment after signing the app. Disabling it is useful for signing with self-signed certificates.
+    Gatekeeper assessment is enabled by default on ``darwin'' platform.
+
   --platform=platform
     Build platform of Electron.
     Allowed values: ``darwin'', ``mas''.

bin/electron-osx-sign.js

@@ -6,11 +6,13 @@ var args = require('minimist')(process.argv.slice(2), {
   'boolean': [
     'help',
     'pre-auto-entitlements',
-    'pre-embed-provisioning-profile'
+    'pre-embed-provisioning-profile',
+    'gatekeeper-assess'
   ],
   'default': {
     'pre-auto-entitlements': true,
-    'pre-embed-provisioning-profile': true
+    'pre-embed-provisioning-profile': true,
+    'gatekeeper-assess': true
   }
 })
 var usage = fs.readFileSync(path.join(__dirname, 'electron-osx-sign-usage.txt')).toString()

index.d.ts

@@ -10,6 +10,7 @@ interface SignOptions extends BaseSignOptions {
   binaries?: string[];
   entitlements?: string;
   'entitlements-inherit'?: string;
+  'gatekeeper-check'?: boolean;
 }
 
 export function sign(opts: SignOptions, callback: (error: Error) => void): void;

sign.js

@@ -103,7 +103,7 @@ function verifySignApplicationAsync (opts) {
   })
 
   // Additionally test Gatekeeper acceptance for darwin platform
-  if (opts.platform === 'darwin') {
+  if (opts.platform === 'darwin' && opts['gatekeeper-assess'] !== false) {
     promise = promise.then(function () {
       return new Promise(function (resolve, reject) {
         debuglog('Verifying Gatekeeper acceptance for darwin platform...')