docs: update doc #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
reviewed
Jun 26, 2019
Kilian
requested changes
Jun 26, 2019
Co-Authored-By: Mark Lee <[email protected]>
Kilian
reviewed
Jul 9, 2019
Kilian
approved these changes
Oct 9, 2019
MarshallOfSound
approved these changes
Nov 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct the ascProvider parameter doc: this is not necessarily the team id, it should be the team short name as stated in the apple developer forum. https://forums.developer.apple.com/thread/113798 and I've tested this and proved that for our app the team id doesn't work because our team short name is different than our team id.
adding some preliminary doc about signing requirement of harden-runtime and the entitlement, looking for suggestions on that part.