Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: publish API documentation #217

Merged
merged 14 commits into from
Dec 7, 2024
Prev Previous commit
Next Next commit
add workflow dispatch
  • Loading branch information
erickzhao committed Nov 30, 2024
commit 672d9cb6ed199796dcd7ead5546f41f7cbcb2d96
1 change: 1 addition & 0 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
name: Publish API documentation

on:
workflow_dispatch:
erickzhao marked this conversation as resolved.
Show resolved Hide resolved
push:
tags:
- v[0-9]+.[0-9]+.[0-9]+*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we confirm tags are protected on this repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also limit the secrets to an environment which is restricted to these tags.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have access to the exact rulesets without admin permissions but I am unable to delete tags via the GitHub UI so I'm guessing yes?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the secrets to the publish-docs env, we should be good to go here 👍