Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow notarization on macOS versions down to 10.15 #201

Merged
merged 6 commits into from
Sep 17, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Removed unnecessary typeof uses
pjaspinski committed Aug 26, 2024
commit bc10d6e73288cb198decb545907f15d76da22c26
4 changes: 2 additions & 2 deletions src/notarytool.ts
Original file line number Diff line number Diff line change
@@ -13,7 +13,7 @@ import { NotaryToolCredentials, NotaryToolStartOptions } from './types';
const d = debug('electron-notarize:notarytool');

function runNotaryTool(args: string[], notarytoolPath?: string) {
const useXcrun = typeof notarytoolPath === 'undefined';
const useXcrun = notarytoolPath === undefined;
const cmd = useXcrun ? 'xcrun' : notarytoolPath;
return spawn(cmd, useXcrun ? ['notarytool', ...args] : args);
}
@@ -61,7 +61,7 @@ async function getNotarizationLogs(opts: NotaryToolStartOptions, id: string) {
}

export async function isNotaryToolAvailable(notarytoolPath?: string) {
if (typeof notarytoolPath !== 'undefined') {
if (notarytoolPath !== undefined) {
const result = await spawn(notarytoolPath, ['--version']);
return result.code === 0;
} else {