Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notarization logs to debug logging for success #202

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

erickzhao
Copy link
Member

Closes #139

Also adds the nice touch of adding the notarization job ID to debug logs as well

@erickzhao erickzhao requested a review from a team as a code owner June 6, 2024 23:54
@erickzhao erickzhao requested a review from MarshallOfSound June 6, 2024 23:54
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgexu99 georgexu99 merged commit dfbdcd8 into main Aug 13, 2024
4 checks passed
@georgexu99 georgexu99 deleted the feat/logs-on-success branch August 13, 2024 21:32
Copy link

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include notarization log in debug output regardless of notarization result
4 participants