Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include notarization log in debug output regardless of notarization result #139

Closed
larrywalters opened this issue Jun 14, 2023 · 3 comments · Fixed by #202
Closed

Include notarization log in debug output regardless of notarization result #139

larrywalters opened this issue Jun 14, 2023 · 3 comments · Fixed by #202
Labels
enhancement New feature or request released

Comments

@larrywalters
Copy link

larrywalters commented Jun 14, 2023

According to Apple's documentation, it is recommended to always check the notarization log, even if the request succeeds. This is because there may be warnings included which would be helpful to the developer(s). It makes sense therefore to always print the log in the debug output.

Therefore, I suggest making the following change in notarytool.ts:
ProposedDff

@nikwen
Copy link

nikwen commented Jun 22, 2023

Great idea! What do you think about submitting your change as a PR?

@MarshallOfSound
Copy link
Member

PRs welcome 💯

Copy link

🎉 This issue has been resolved in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants