fix bug with lts computation for node 10 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chained comparisons don't work in node, `a < b < c` is equivalent to `(a < b) < c`, i.e. coerce the boolean `(a < b)` to an integer (0 for false, 1 for true) and then compare that to `c`. So this `lts` test would always have been `true`, since both `0` and `1` are less than `+new Date(2020, 4, 31)`
MarshallOfSound
approved these changes
Feb 11, 2019
|
🎉 This PR is included in version 2.7.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chained comparisons don't work in node,
a < b < cis equivalent to(a < b) < c, i.e. coerce the boolean(a < b)to an integer (0 for false, 1 for true) and then compare that toc. So thisltstest would always have beentrue, since both0and1are less than+new Date(2020, 4, 31)