Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump dependencies, require node 4, remove home-path dependency #40

Closed
wants to merge 2 commits into from
Closed

bump dependencies, require node 4, remove home-path dependency #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32cb2af
bump dependencies, require node 4, remove home-path dependency
develar Nov 18, 2016
cfe9c28
resolve merge conflicts
develar Feb 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,10 @@ os:
osx_image: xcode7.3
language: node_js
node_js:
- '0.10'
- '0.12'
- '4'
- '5'
- '6'
- '7'
cache:
- directories:
- "$HOME/.npm"
Expand Down
3 changes: 1 addition & 2 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

const debug = require('debug')('electron-download')
const fs = require('fs-extra')
const homePath = require('home-path')
const rc = require('rc')
const nugget = require('nugget')
const os = require('os')
Expand Down Expand Up @@ -44,7 +43,7 @@ class ElectronDownloader {
}

get cache () {
return this.opts.cache || path.join(homePath(), './.electron')
return this.opts.cache || path.join(os.homedir(), './.electron')
}

get cachedChecksum () {
Expand Down
36 changes: 19 additions & 17 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,26 +23,25 @@
},
"homepage": "https://github.com/electron-userland/electron-download#readme",
"dependencies": {
"debug": "^2.2.0",
"fs-extra": "^0.30.0",
"home-path": "^1.0.1",
"debug": "^2.6.0",
"fs-extra": "^2.0.0",
"minimist": "^1.2.0",
"nugget": "^2.0.0",
"path-exists": "^2.1.0",
"rc": "^1.1.2",
"nugget": "^2.0.1",
"path-exists": "^3.0.0",
"rc": "^1.1.6",
"semver": "^5.3.0",
"sumchecker": "^1.2.0"
"sumchecker": "^2.0.1"
},
"devDependencies": {
"babel-cli": "^6.14.0",
"babel-preset-es2015": "^6.14.0",
"babel-register": "^6.14.0",
"eslint": "^3.2.0",
"eslint-config-standard": "^5.2.0",
"eslint-plugin-promise": "^2.0.0",
"eslint-plugin-standard": "^2.0.0",
"babel-cli": "^6.22.2",
"babel-preset-es2015-node4": "^2.1.1",
"babel-register": "^6.22.0",
"eslint": "^3.14.1",
"eslint-config-standard": "^6.2.1",
"eslint-plugin-promise": "^3.4.0",
"eslint-plugin-standard": "^2.0.1",
"mkdirp": "^0.5.1",
"tape": "^4.6.0",
"tape": "^4.6.3",
"temp": "^0.8.3"
},
"eslintConfig": {
Expand All @@ -58,8 +57,11 @@
},
"babel": {
"presets": [
"es2015"
"es2015-node4"
]
},
"keywords": []
"keywords": [],
"engines": {
"node": ">= 4.0"
}
}
4 changes: 2 additions & 2 deletions test/test_bad_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@

const download = require('../lib/index')
const fs = require('fs')
const homePath = require('home-path')
const os = require('os')
const mkdirp = require('mkdirp').sync
const path = require('path')
const test = require('tape')
const verifyDownloadedZip = require('./helpers').verifyDownloadedZip

test('bad config test', (t) => {
const configPath = path.join(homePath(), '.config', 'npm', 'config')
const configPath = path.join(os.homedir(), '.config', 'npm', 'config')
mkdirp(path.dirname(configPath))
fs.writeFileSync(configPath, '{')

Expand Down