refactor(Cache): replace sanitize-filename with filenamify #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's extremely difficult to upgrade `sanitize-filename` from 1.6.2 to 1.6.3, as they merged their TypeScript typings into the package. As a result, the recommended import statement to use it does not seem to work with both CJS and ESM configurations. The options used with `filenamify` should be compatible with the default options of `sanitize-filename`.
5 tasks
ckerr
approved these changes
Jun 8, 2020
|
🎉 This PR is included in version 1.12.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's extremely difficult to upgrade
sanitize-filenamefrom 1.6.2 to 1.6.3, as they merged their TypeScript typings into the package. As a result, the recommended import statement to use it does not seem to work with both CJS and ESM configurations.The options used with
filenamifyshould be compatible with the default options ofsanitize-filename.