fix(initializer): electron versions for babel-preset-env should be strings #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rings Removes the following warning when running `electron-forge start`: > Warning, the following targets are using a decimal version: > > electron: 1.7 > > We recommend using a string for minor/patch versions to avoid numbers like 6.10 > getting parsed as 6.1, which can lead to unexpected behavior.
MarshallOfSound
approved these changes
Dec 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are appropriately documented(not applicable).Summarize your changes:
Forge changed to floats in #187 due to a break in
babel-preset-env. The Babel folks added proper support for strings as versions in v1.5.0 via babel/babel-preset-env#321, about 1.5 months later (we require^1.6.0already).Removes the following warning when running
electron-forge start: