Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle missing manifest in zip maker #3405

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: handle missing manifest in zip maker #3405

merged 1 commit into from
Nov 9, 2023

Conversation

MarshallOfSound
Copy link
Member

Fixes #3378

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner November 9, 2023 18:03
@MarshallOfSound MarshallOfSound merged commit b4f6dd9 into main Nov 9, 2023
8 checks passed
@MarshallOfSound MarshallOfSound deleted the handle-missing-manifest branch November 9, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@electron-forge/maker-zip: If using macUpdateManifestBaseUrl and RELEASES.json doesn't exist in S3, fails
2 participants
@MarshallOfSound @erickzhao