Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker-snap): allow MakerSnapConfig to also be SnapcraftConfig #1725

Merged
merged 1 commit into from
May 30, 2020

Conversation

malept
Copy link
Member

@malept malept commented May 29, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Try to make it more obvious where to put custom snapcraft.yaml config.

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #1725 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1725   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files          74       74           
  Lines        2189     2189           
  Branches      412      412           
=======================================
  Hits         1538     1538           
  Misses        465      465           
  Partials      186      186           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f77a087...6401ba4. Read the comment docs.

@malept malept merged commit 19b64ef into master May 30, 2020
@malept malept deleted the maker-snap/fix/snapcraft-config branch May 30, 2020 01:06
@RobbieTheWagner
Copy link

Are there any docs on how to use a custom config?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants