Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maker-flatpak): add eu-strip to required external binaries #1703

Merged
merged 1 commit into from
May 23, 2020

Conversation

malept
Copy link
Member

@malept malept commented May 23, 2020

Summarize your changes:

Needed due to zypak sandboxing for Electron >= 5.

Corresponding docs update: electron-forge/electron-forge-docs@2aa0f59

Fixes #1702

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #1703 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1703   +/-   ##
=======================================
  Coverage   70.26%   70.26%           
=======================================
  Files          74       74           
  Lines        2189     2189           
  Branches      412      412           
=======================================
  Hits         1538     1538           
  Misses        465      465           
  Partials      186      186           
Impacted Files Coverage Δ
packages/maker/flatpak/src/MakerFlatpak.ts 86.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49a9ba6...7f3bc53. Read the comment docs.

Needed due to zypak sandboxing for Electron >= 5.
@malept malept force-pushed the maker-flatpak/eu-strip-external-binary branch from 47e9b92 to 7f3bc53 Compare May 23, 2020 18:19
@malept malept merged commit 4314e1d into master May 23, 2020
@malept malept deleted the maker-flatpak/eu-strip-external-binary branch May 23, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@electron-forge/maker-flatpak error after project setup
1 participant