Cannot find module 'appdmg' #2807

jgunzelman88 · 2022-04-18T20:16:53Z

Pre-flight checklist

I have read the contribution documentation for this project.
I agree to follow the code of conduct that this project uses.
I have searched the issue tracker for a bug that matches the one I want to file, without success.

Electron Forge version

6.0.0-beta.63

Electron version

v17.4.0

Operating system

12.3.1

Last known working Electron Forge version

No response

Expected behavior

I am trying to build a dmg installer. I install the package and expected it to work since the documentation you provided is pretty limited.

Actual behavior

I installed @electron-forge/maker-dmg then I installed appdmg and verified it was installed but now I still get this error.

`
An unhandled error has occurred inside Forge:
An error occured while making for target: dmg
Cannot find module 'appdmg'
Require stack:

/Users/user/Workspaces/personal/PokeTrax/node_modules/electron-installer-dmg/src/index.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/maker-dmg/dist/MakerDMG.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/dist/util/require-search.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/dist/util/plugin-interface.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/dist/util/forge-config.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/dist/api/import.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/dist/api/index.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/cli/dist/electron-forge-make.js
Error: Cannot find module 'appdmg'
Require stack:
/Users/user/Workspaces/personal/PokeTrax/node_modules/electron-installer-dmg/src/index.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/maker-dmg/dist/MakerDMG.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/dist/util/require-search.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/dist/util/plugin-interface.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/dist/util/forge-config.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/dist/api/import.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/dist/api/index.js
/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/cli/dist/electron-forge-make.js
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Module.require (node:internal/modules/cjs/loader:999:19)
at require (node:internal/modules/cjs/helpers:102:18)
at build (/Users/user/user/Workspaces/personal/PokeTrax/node_modules/electron-installer-dmg/src/index.js:121:10)
at MakerDMG.make (/Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/maker-dmg/src/MakerDMG.ts:32:18)
at /Users/user/Workspaces/personal/PokeTrax/node_modules/@electron-forge/core/src/api/make.ts:217:31`

Steps to reproduce

Project is Opensource and main is the lastest
https://github.com/jgunzelman88/PokeTrax
just run npm run make

Thanks for the help!!

Additional information

No response

Boanerges1996 · 2022-04-20T13:17:52Z

I faced a similar issue what I did was install appdmg as a dev dependency and that solved my issue. I think the electron team has to find a fix for it though.

mahnunchik · 2022-11-09T11:12:36Z

Cannot find module 'appdmg'

I've faced with the same issue. It works without any problem for a while.

sboudouk · 2022-11-14T17:58:48Z

Same issue here. Any fix ? Adding appdmg as dev dependency result in node-gyp error.

mahnunchik · 2022-11-14T18:08:36Z

My workaround is to specify python version for GitHub action:

- uses: actions/setup-python@v4
  with:
    python-version: '3.10'

s-a · 2023-04-08T06:59:33Z

Thanks to #2176 (comment) I removed package-lock.json to fix github build action. This is also related to #2176 .

dtcooper · 2023-11-04T18:00:52Z

My workaround is to specify python version for GitHub action:
- uses: actions/setup-python@v4
  with:
    python-version: '3.10'

Using Python 3.11 instead of the bundled Python 3.12 fixed it for me using the macos-11 runner with GitHub actions. (My relevant commit that fixed it for reference.)

Appears related to LinusU/node-appdmg#234 and nodejs/node-gyp#2869

Summary: [ENG-5678](https://linear.app/comm/issue/ENG-5678) The general error that breaks the github CI is the same as in this [issue](electron/forge#2807) - `distutils` was removed in a newer version of python and so one of the dependencies postinstall script breaks because of that. This diff fixes that by additionaly installing an older (3.10) version of python before installing the dependencies. Note that I'm still not sure why the CI is sometimes successful but I'm hoping this should fix the errors. INFO: Most native (written in C++) js modules are built with something called `node-gyp`. It's written in python and used at build time in postinstall scripts. That's why we need to mess with python. Test Plan: Tested on a GitHub fork. Without this changes CI failed. After this changes tried running it 3 times and it succeded every time. Reviewers: atul, ashoat, tomek Reviewed By: ashoat Subscribers: wyilio Differential Revision: https://phab.comm.dev/D9760

Try to resolve appdmg module can not found issue in ci/cd pipeline electron/forge#2807 (comment)

blee-tetrascience · 2023-11-20T22:56:17Z

This was driving me crazy today trying to track down. Thanks for posting this @dtcooper. Locking in Python 3.11 did the trick

dtcooper · 2023-11-20T23:52:39Z

Glad it helped! @blee-tetrascience :)

hata6502 · 2024-02-21T18:18:35Z

I've resolved this issue on macos-latest by adding python3 -m pip install setuptools at the first step.

    steps:
      # https://github.com/electron/forge/issues/2807
      - run: python3 -m pip install setuptools

      - uses: actions/checkout@v4
      - uses: actions/setup-node@v4
        with:
          node-version: 20
      - run: npm ci

jgresham · 2024-04-23T17:14:27Z

It looks like GHA mac runner has installed brew and python in some new way which is now giving an error. The --break-system-packages flag fixes the error for me (I don't use python for other things in my actions) so my command is now: python3 -m pip install setuptools --break-system-packages

New error:

Run python3 -m pip install setuptools
  python3 -m pip install setuptools
  shell: /bin/bash -e {0}
error: externally-managed-environment

× This environment is externally managed
╰─> To install Python packages system-wide, try brew install
    xyz, where xyz is the package you are trying to
    install.
    
    If you wish to install a Python library that isn't in Homebrew,
    use a virtual environment:
    
    python[3](https://github.com/NiceNode/nice-node/actions/runs/8803883604/job/24163039602#step:2:3) -m venv path/to/venv
    source path/to/venv/bin/activate
    python3 -m pip install xyz
    
    If you wish to install a Python application that isn't in Homebrew,
    it may be easiest to use 'pipx install xyz', which will manage a
    virtual environment for you. You can install pipx with
    
    brew install pipx
    
    You may restore the old behavior of pip by passing
    the '--break-system-packages' flag to pip, or by adding
    'break-system-packages = true' to your pip.conf file. The latter
    will permanently disable this error.
    
    If you disable this error, we STRONGLY recommend that you additionally
    pass the '--user' flag to pip, or set 'user = true' in your pip.conf
    file. Failure to do this can result in a broken Homebrew installation.
    
    Read more about this behavior here: <https://peps.python.org/pep-0[6](https://github.com/NiceNode/nice-node/actions/runs/8803883604/job/24163039602#step:2:7)68/>

note: If you believe this is a mistake, please contact your Python installation or OS distribution provider. You can override this, at the risk of breaking your Python installation or OS, by passing --break-system-packages.
hint: See PEP 66[8](https://github.com/NiceNode/nice-node/actions/runs/8803883604/job/24163039602#step:2:9) for the detailed specification.
Error: Process completed with exit code 1.

jgunzelman88 added the bug label Apr 18, 2022

jgunzelman88 closed this as completed Apr 20, 2022

xwcoder added a commit to xwcoder/emo that referenced this issue Nov 13, 2023

chore: remove package-lock.json

90a9273

Try to resolve appdmg module can not found issue in ci/cd pipeline electron/forge#2807 (comment)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cannot find module 'appdmg' #2807

Cannot find module 'appdmg' #2807

jgunzelman88 commented Apr 18, 2022

Boanerges1996 commented Apr 20, 2022

mahnunchik commented Nov 9, 2022

sboudouk commented Nov 14, 2022

mahnunchik commented Nov 14, 2022

s-a commented Apr 8, 2023

dtcooper commented Nov 4, 2023 •

edited

Loading

blee-tetrascience commented Nov 20, 2023

dtcooper commented Nov 20, 2023

hata6502 commented Feb 21, 2024 •

edited

Loading

jgresham commented Apr 23, 2024

Cannot find module 'appdmg' #2807

Cannot find module 'appdmg' #2807

Comments

jgunzelman88 commented Apr 18, 2022

Pre-flight checklist

Electron Forge version

Electron version

Operating system

Last known working Electron Forge version

Expected behavior

Actual behavior

Steps to reproduce

Additional information

Boanerges1996 commented Apr 20, 2022

mahnunchik commented Nov 9, 2022

sboudouk commented Nov 14, 2022

mahnunchik commented Nov 14, 2022

s-a commented Apr 8, 2023

dtcooper commented Nov 4, 2023 • edited Loading

blee-tetrascience commented Nov 20, 2023

dtcooper commented Nov 20, 2023

hata6502 commented Feb 21, 2024 • edited Loading

jgresham commented Apr 23, 2024

dtcooper commented Nov 4, 2023 •

edited

Loading

hata6502 commented Feb 21, 2024 •

edited

Loading