Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sample test files to templates #138

Closed
chadbr opened this issue Feb 17, 2017 · 4 comments
Closed

Add sample test files to templates #138

chadbr opened this issue Feb 17, 2017 · 4 comments

Comments

@chadbr
Copy link

chadbr commented Feb 17, 2017

Are there any plans to integrate testing framework(s) into the tool / templates?

I'm thinking in terms of ng test from the angular-cli.

Maybe I'm missing something (new here!)

@malept
Copy link
Member

malept commented Feb 17, 2017

We would welcome a PR to add really basic test files for the angular2 template in https://github.com/electron-userland/electron-forge-templates. They would have to be formatted in whatever the popular convention is for Angular projects.

However, I think what would be even better would be if someone wrote a plugin for angular-cli. There is already progress on a similar plugin for Forge with Ember.

@malept malept changed the title Tests? Add sample test files to templates Feb 17, 2017
@chadbr
Copy link
Author

chadbr commented Feb 17, 2017

Yea - last I looked - they removed the plug-ins from cli unfortunately. -- angular/angular-cli#3901

I think they have plans for something else in the future (probably webpack based?)

@malept
Copy link
Member

malept commented Feb 17, 2017

they removed the plug-ins from cli unfortunately.

That is indeed unfortunate.

@MarshallOfSound
Copy link
Member

IMO this breaches the scope of electron-forge, our goal is to provide a minimal entry point into Electron, I don't want our templates to become bloated 100 file "boilerplate" style proejcts, I personally find boilerplates ridiculously opinionated, normally way over the top and almost always include way too much, well, boilerplate 😆

If this is something people want we can discuss it over at https://github.com/electron-userland/electron-forge-templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants