make test gooder

electron · Mar 3, 2022 · e4c6a1f · e4c6a1f
1 parent f5407a7
commit e4c6a1f
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 14 deletions.
diff --git a/packages/api/core/test/fast/make_spec.ts b/packages/api/core/test/fast/make_spec.ts
@@ -12,18 +12,16 @@ describe('make', () => {
   it('works with scoped package names', async () => {
     const stubbedMake: (opts: MakeOptions) => Promise<ForgeMakeResult[]> = proxyquire.noCallThru().load('../../src/api/make', {
       '../util/read-package-json': {
-        readMutatedPackageJson: () => Promise.resolve(require('../fixture/dummy_app_scoped_name/package.json')),
+        readMutatedPackageJson: () => Promise.resolve(require('../fixture/app-with-scoped-name/package.json')),
       },
     }).default;
-    await expect(
-      stubbedMake({
-        arch: 'x64',
-        dir: path.join(fixtureDir, 'maker-scoped'),
-        overrideTargets: ['@electron-forge/maker-zip'],
-        platform: 'linux',
-        skipPackage: true,
-      })
-    ).to.eventually.be.rejectedWith(/@scope-package-linux-x64/);
+    await stubbedMake({
+      arch: 'x64',
+      dir: path.join(fixtureDir, 'app-with-scoped-name'),
+      overrideTargets: ['@electron-forge/maker-zip'],
+      platform: 'linux',
+      skipPackage: true,
+    });
     after(() => proxyquire.callThru());
   });
 

diff --git a/packages/api/core/test/fixture/app-with-scoped-name/out/@scope-package-linux-x64/.gitkeep b/packages/api/core/test/fixture/app-with-scoped-name/out/@scope-package-linux-x64/.gitkeep
diff --git a/...st/fixture/app-with-scoped-name/out/make/zip/linux/x64/@scope-package-linux-x64-1.0.0.zip b/...st/fixture/app-with-scoped-name/out/make/zip/linux/x64/@scope-package-linux-x64-1.0.0.zip
diff --git a/...ixture/dummy_app_scoped_name/package.json → ...fixture/app-with-scoped-name/package.json b/...ixture/dummy_app_scoped_name/package.json → ...fixture/app-with-scoped-name/package.json
@@ -12,10 +12,14 @@
   "license": "MIT",
   "config": {
     "forge": {
-      "packagerConfig": {
-        "baz": {}
-      },
-      "s3": {}
+      "makers": [
+        {
+          "name": "@electron-forge/maker-zip",
+          "platforms": [
+            "linux"
+          ]
+        }
+      ]
     }
   },
   "devDependencies": {