fix(core): Re-throw non-require errors when using requireSearch (#1876)

Co-authored-by: Mark Lee <[email protected]>

packages/api/core/src/util/require-search.ts

@@ -14,7 +14,10 @@ export function requireSearchRaw<T>(relativeTo: string, paths: string[]): T | nu
       // eslint-disable-next-line global-require, import/no-dynamic-require
       return require(testPath);
     } catch (err) {
-      // Ignore the error
+      // Ignore require-related errors
+      if (err.code !== 'MODULE_NOT_FOUND' || ![undefined, testPath].includes(err.requestPath)) {
+        throw err;
+      }
     }
   }
   d('failed to find a module in', testPaths);

packages/api/core/test/fast/require-search_spec.ts

@@ -13,4 +13,10 @@ describe('require-search', () => {
     const resolved = requireSearch(__dirname, ['../../src/util/forge-config']);
     expect(resolved).to.equal(findConfig);
   });
+
+  it('should throw if file exists but fails to load', () => {
+    expect(() => {
+      requireSearch(__dirname, ['../fixture/require-search/throw-error']);
+    }).to.throw('test');
+  });
 });

packages/api/core/test/fixture/require-search/throw-error.js

@@ -0,0 +1 @@
+throw new Error('test');