Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove types from GTK CSS selectors #39003

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: remove types from GTK CSS selectors #39003

merged 1 commit into from
Jul 10, 2023

Conversation

aiddya
Copy link
Contributor

@aiddya aiddya commented Jul 6, 2023

Description of Change

Remove types from GTK CSS selectors similar to Chromium's changes in CL 4289229.

Fixes #38786

Checklist

Release Notes

Notes: Fixed display of title bar buttons on Wayland.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 6, 2023
codebytere
codebytere approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/25-x-y PR should also be added to the "25-x-y" branch. target/26-x-y PR should also be added to the "26-x-y" branch. labels Jul 6, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 7, 2023
@codebytere
Copy link
Member

@aiddya could you please rebase this?

@aiddya
fix: remove types from GTK CSS selectors
00c47d0 
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.

Fixes electron#38786
@aiddya
Copy link
Contributor Author

aiddya commented Jul 10, 2023

Done.

@codebytere codebytere merged commit 3e31520 into electron:main Jul 10, 2023
@welcome
Copy link

welcome bot commented Jul 10, 2023

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk
Copy link

release-clerk bot commented Jul 10, 2023

Release Notes Persisted

Fixed display of title bar buttons on Wayland.

This was referenced Jul 10, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jul 10, 2023

I have automatically backported this PR to "25-x-y", please check out #39044

@trop trop bot added in-flight/25-x-y and removed target/25-x-y PR should also be added to the "25-x-y" branch. labels Jul 10, 2023
@trop
Copy link
Contributor

trop bot commented Jul 10, 2023

I have automatically backported this PR to "26-x-y", please check out #39045

@trop trop bot added in-flight/26-x-y merged/25-x-y PR was merged to the "25-x-y" branch. and removed target/26-x-y PR should also be added to the "26-x-y" branch. in-flight/25-x-y labels Jul 10, 2023
@aiddya aiddya deleted the gtk-css-fix branch July 11, 2023 02:50
@trop trop bot added merged/26-x-y PR was merged to the "26-x-y" branch. and removed in-flight/26-x-y labels Jul 11, 2023
@enigma9o7 enigma9o7 mentioned this pull request Jul 12, 2023
Closed
@commit-lint commit-lint bot mentioned this pull request Sep 21, 2023
Open
MrHuangJser pushed a commit to MrHuangJser/electron that referenced this pull request Dec 11, 2023
@aiddya
fix: remove types from GTK CSS selectors (electron#39003)
71d5c6c 
Remove types from GTK CSS selectors similar to Chromium's changes in CL
4289229.

Fixes electron#38786

Co-authored-by: Athul Iddya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
merged/25-x-y PR was merged to the "25-x-y" branch. merged/26-x-y PR was merged to the "26-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wayland csd on gnome are broke for 25.x and newer.
2 participants
@aiddya @codebytere