Fix capturePage for Electron 2.0 #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated capturePage to use NativeImage.toPNG
|
The CI failures are unrelated and shouldn't block this PR. The cause of the CI failures is tracked in #295 |
|
Is there any way to get this published as |
|
Same here. We have upgraded electron to 2.0.3 and have exactly the same issue. |
|
Facing the same issue afte the electron 2.0.3 upgrade in our project. |
|
What is the status on a 3.8.1 release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Electron
1.2.5, thetoPngwas changed totoPNGand deprecated. (electron/electron@e922258)In Electron
2.0.0, thetoPngwas removed, and onlytoPNGexists now.This PR ensures
capturePageis compatible with Electron 2.0, but still works with Electron >= 1.2.5.