Skip to content

Commit

Permalink
fix: start dev-server despite of compiler warnings (#305)
Browse files Browse the repository at this point in the history
  • Loading branch information
almini authored and loopmode committed Jul 9, 2019
1 parent 287cb2b commit cf81c8e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/electron-webpack/src/dev/WebpackDevServerManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export async function startRenderer(projectDir: string, env: any) {

const r = resolve
// we must resolve only after compilation, otherwise devtools disconnected
if (r != null && data.includes(": Compiled successfully.")) {
if (r != null && (data.includes(": Compiled successfully.") || data.includes(": Compiled with warnings."))) {
resolve = null
r()
}
Expand Down Expand Up @@ -103,4 +103,4 @@ class CompoundRendererLineFilter implements LineFilter {
filter(line: string) {
return !this.filters.some(it => !it.filter(line))
}
}
}

0 comments on commit cf81c8e

Please sign in to comment.