fix(darwin): ensure chrome-sandbox is owned by root #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
changed the title
|
I'll need to update the required checks after this is merged. |
fcastilloec
reviewed
May 11, 2021
| @@ -10,15 +10,16 @@ on: | |||
|
|
|||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| runs-on: ${{ matrix.os }} | |||
| strategy: | |||
| matrix: | |||
| node-version: [10.x, 12.x, 14.x] | |||
There was a problem hiding this comment.
should we add testing for node 16 in this PR?
There was a problem hiding this comment.
I'd rather deal with that in the Node 10 PR.
fcastilloec
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in
fakerooton macOS where it doesn't correctly set the owner/group of files, includingchrome-sandbox. This behavior prevents the Electron app from starting. The fix is to force all of the files to be owned by root via adpkgflag. It's only in dpkg >= 1.19.0, but Homebrew has 1.20.9 as of the creation of this PR, so I'm gating the addition of the flag based on the host platform, just to avoid bug reports from users who insist on using extremely old Linux distributions.Related: since we support using it on macOS, we should run the tests on it too.
Unrelated: I replaced
.npmignorewith afilesarray inpackage.json.