Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch from Travis CI to GitHub Actions #242

Merged
merged 2 commits into from
Feb 6, 2021
Merged

Conversation

fcastilloec
Copy link
Collaborator

@fcastilloec fcastilloec commented Feb 3, 2021

In addition to this PR, and admin will have to remove/uninstall Travis from this repo, and change the required checks for PRs.

Also, not necessarily related to this PR, we can remove the WIP check since GitHub now allows to convert PRs into drafts.

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall, I'm going to commit my suggestions and then merge.

@malept malept merged commit fc4a7c7 into master Feb 6, 2021
@malept malept deleted the github-actions branch February 6, 2021 18:32
@malept
Copy link
Member

malept commented Feb 6, 2021

FYI, while I was in the branch settings, I took the liberty of renaming the default branch to main (as well as in -redhat) and updated the references inside the repository accordingly.

@fcastilloec
Copy link
Collaborator Author

@malept that's great! I've been wanting that to happen for a while but I don't have the permission to do it.
I opened an issue for -windows electron-userland/electron-installer-windows#333
If possible, can you do the same for -common?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants