Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #146

Merged
merged 1 commit into from
Oct 5, 2018
Merged

Release 1.0.0 #146

merged 1 commit into from
Oct 5, 2018

Conversation

malept
Copy link
Member

@malept malept commented Oct 5, 2018

🎉 🎉

Fixes #136.

@malept malept requested a review from fcastilloec October 5, 2018 06:28
Copy link
Collaborator

@fcastilloec fcastilloec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So glad to see we're at 1.0.0

@malept malept merged commit be26603 into master Oct 5, 2018
@malept malept deleted the release-1.0.0 branch October 5, 2018 23:52
@malept
Copy link
Member Author

malept commented Oct 6, 2018

Well, I tried to publish and it didn't work: https://travis-ci.org/unindented/electron-installer-debian/jobs/437873831#L2273-L2289

@unindented I think the NPM API key in Travis needs to be updated. Once that's fixed, we can delete the 1.0.0 tag and try again.

@fcastilloec
Copy link
Collaborator

Yes, @unindented needs to updated the API key. I forgot that npm invalidated all tokens issued before 2018-07-12 due to a security breach. https://status.npmjs.org/incidents/dn7c1fgrr7ng

@unindented
Copy link
Collaborator

Sorry folks, I was busy moving apartments... I'll update now.

Also @malept, @fcastilloec can you confirm your npmjs.org aliases? I'll add you as collaborators there.

@unindented
Copy link
Collaborator

Also, would you be ok with moving this under the electron-userland org? Who would we contact?

(I feel bad having my name attached to this project now that you two are doing all the work.)

@unindented
Copy link
Collaborator

@malept @fcastilloec I've manually published 1.0.0 in the meantime, and opened a PR to update the npm key: #147

I'll be doing the same for electron-installer-redhat.

@fcastilloec
Copy link
Collaborator

@unindented Thanks for pushing the new version manually. My npmjs.org username is fcastilloec

@malept
Copy link
Member Author

malept commented Oct 8, 2018

can you confirm your npmjs.org aliases?

I'm malept there as well.

Also, would you be ok with moving this under the electron-userland org? Who would we contact?

I'm OK with this, but I may be biased as I'm one of the electron-userland admins 😄

@unindented
Copy link
Collaborator

@malept haha awesome. Could you drive the move of both electron-installer-debian and electron-installer-redhat? Feel free to change all copyright notices, URLs, and whatever you need to be compatible with the new org.

(I don't know if anybody is interested in electron-installer-windows because of the overlap with electron-winstaller, but I'm cool with moving that one too.)

@malept
Copy link
Member Author

malept commented Oct 8, 2018

@unindented the only thing you're required to do is accept the electron-userland org invite, and transfer ownership of the repos to the org.

@unindented
Copy link
Collaborator

LET'S DO IT

@fcastilloec
Copy link
Collaborator

I'm not an admin at electron-userland so if we move, I'm not sure if they will add me as an admin there. Nonetheless, I'll keep contributing.

@unindented
Copy link
Collaborator

@malept done for all three repos. Can you make sure @fcastilloec keeps necessary access to them?

Thank you both for keeping these projects alive! 🙌

@malept
Copy link
Member Author

malept commented Oct 8, 2018

@fcastilloec you'll still be a contributor to the three repos, it's not necessary to be an admin/member of the org.

@malept
Copy link
Member Author

malept commented Oct 8, 2018

I will work on updating the URLs and such some time this week (my month just got very busy) unless @fcastilloec beats me to it.

I also need to add the packages to the electron-userland NPM org. Edit: This is done.

@unindented
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants