feat: Add directory prompt page in boring installer #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick n dirty change which works for me. I just wanted to keep these changes in this pull-request to elaborate and discuss on it. Regard this as a starting point to solve electron-userland#596. Still lacking are e.g. tests, of course.
|
@domachine, thanks for your PR! By analyzing the history of the files in this pull request, we identified @develar to be a potential reviewer. |
|
@develar Should I introduce an option to disable this page? |
|
Yes, I think, we should not promote it and so, do not use it by default. Proposed option: |
|
👍 |
|
Usually I don't bother pull request author and make all required changes myself, but if you want to prepare merge-ready PR — that's great :) |
|
@develar I'd love to :) |
|
What's the status of this? I could really use this ability. |
|
@noahbenham Option should be added, please see #909 (comment) |
|
Hey, sorry I've been so busy since I started this PR. Hope to find some time this evening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick n dirty change which works for me. I just wanted to keep these changes in this pull-request to elaborate and discuss on it. Regard this as a starting point to solve #596. Still lacking are e.g. tests, of course.