fix: support including node_modules in other subdirectories

[beyondkmp]

fix #6080 and support including node_modules in other subdirectories

How to fix

1. No file patterns

   • The final File patterns are ["**/*", "!**/node_modules/**", "!dist{,/**/*}", ...]

2. File patterns with other sub node_modules ["/*", "**/sub/node_modules/**"]

   • File patterns are ["**/*", "!**/node_modules/**", "**/sub/node_modules/**", "!dist{,/**/*}", ...]

3. File patterns without sub node_modules

   • The final File patterns are ["**/*", "!**/node_modules/**", "!dist{,/**/*}", ...]

The final patterns above all filter out the node_modules in the app root directory. In filter.ts, we handle this by returning false by default if relative === 'node_modules', so it won't be filtered out.

electron-builder/packages/app-builder-lib/src/util/filter.ts

Lines 60 to 62 in e2c7981

	if (relative === "node_modules") {
	return false
	}

However, if you really want to filter out the node_modules in the app directory, you can use ["!node_modules/**/*"] to filter it.

Two points to note

1. Now ["**/*", "**/sub/node_modules"] cannot match. Only ["**/*", "**/sub/node_modules/**"] will match.

   For a relative path of sub/node_modules, if don't add a / at the end, we can only use **/sub/node_module to match. If add a / at the end, we can only use **/sub/node_module/** to match.

   I currently prefer that **/sub/node_modules/** matches, as this aligns more with conventional usage.

2. */sub/node_modules/** cannot match because the relative path is sub/node_modules, and there's no extra directory at the beginning.

[changeset-bot]

🦋 Changeset detected

Latest commit: e433da5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages

Name	Type
app-builder-lib	Major
builder-util	Major
dmg-builder	Major
electron-builder-squirrel-windows	Major
electron-builder	Major
electron-forge-maker-appimage	Major
electron-forge-maker-nsis-web	Major
electron-forge-maker-nsis	Major
electron-forge-maker-snap	Major
electron-publish	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[netlify]

✅ Deploy Preview for car-park-attendant-cleat-11576 ready!

Name	Link
🔨 Latest commit	e433da5
🔍 Latest deploy log	https://app.netlify.com/sites/car-park-attendant-cleat-11576/deploys/670325527fba5b000846d7c7
😎 Deploy Preview	https://deploy-preview-8562--car-park-attendant-cleat-11576.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.