fix: check if the file already starts with a UTF-8 BOM #8551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9142afa The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
beyondkmp
changed the title
mmaietta
reviewed
Oct 1, 2024
added 2 commits
October 2, 2024 08:13
mmaietta
approved these changes
Oct 2, 2024
Merged
xyloflake
pushed a commit
to xyloflake/electron-builder
that referenced
this pull request
Oct 2, 2024
…land#8551) fix electron-userland#8512 If the file is already in UTF-8 BOM format, there's no need to convert it again. If it's converted again, it will result in garbled characters. --------- Co-authored-by: beyondkmp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8512
If the file is already in UTF-8 BOM format, there's no need to convert it again. If it's converted again, it will result in garbled characters.